Introduce cider-shorten-error-overlays customization option
#3531
Conversation
|
Seems to me we don't really need a defcustom for this. Given that the offending line would already be underlined this should simply be the only behavior. There's no need to make everything customizable. :-) |
|
I tend to agree, but #3338 (reply in thread) showed a reasonable case for the alternative. |
|
Hmm, it seems to me we're solving the wrong problem here - if the highlighting is not precise/useful probably we should improve it. Obviously adding this extra defcustom is not a big deal for us, but it just seems weird to me to have such a high granularity of customizations, that probably almost no one will ever touch. |
|
My take would be that different Clojure developers need/want different degrees of detail, for errors. Personally, I feel that I have seen certain errors so many times, that just a short string will suffice to inform me. But not everyone operates like that. |
This part I get, but I believe that level of granularity is something like a line in an overlay vs a stacktrace buffer. Now we're discussing whether we need a defcustom for a message. Every such branch/defcustom adds some maintenance complexity, that's why it's good to consider carefully their value and their alternatives. |
cider-eval.el
Outdated
| and the suffix matched by `cider-module-info-regexp' will be removed." | ||
| :type 'boolean | ||
| :group 'cider | ||
| :package-version '(cider . "0.19.0")) |
There was a problem hiding this comment.
Btw, this should be 1.9, not 0.19. :-)
|
Maybe a middle ground solution would be to make |
cider-eval.el
Outdated
| @@ -821,6 +821,24 @@ REPL buffer. This is controlled via | |||
| conn))) | |||
| (nrepl-dict-get result "phase")))))) | |||
|
|
|||
| (defcustom cider-shorten-error-overlays t | |||
There was a problem hiding this comment.
I'd name this cider-shorten-inline-errors or cider-shorten-inline-error-messages. I think that the overlay is an implementation detail, that might change in the future, so it's better to focus on the essence (that we should an error message inline).
| @@ -207,6 +207,15 @@ bottom) with the `cider-use-overlays` variable: | |||
| (setq cider-use-overlays nil) | |||
| ---- | |||
|
|
|||
| Overlays that indicate errors are by default trimmed of file/line/phase information. | |||
| If you find it useful, you can customize: | |||
There was a problem hiding this comment.
Might be good to also put two error messages side by side here, so it clearer to people how the messages look in both cases.
Hmm, actually let's make a defcustom which is the function used to process the error message. We can provide the current function as a default for it, and people can set it to |
Fixes #3525